Skip to content

Conversation

@neriousy
Copy link
Contributor

@neriousy neriousy commented Jan 13, 2026

What does this PR do?

Listing files when using "@filename" was not working.
It was passing undefined to searchFiles

How did you verify your code works?

Open dekstop app, prompt @filename

I guess "duplicate" of #8164 and #8186 although I do not think their fixes are appropiate especailly those inline imports

Here's a really quick fix for listing files when using cmd + p or @filename in for prompt

@github-actions
Copy link
Contributor

Hey! Your PR title Fix(app): listing files doesn't follow conventional commit format.

Please update it to start with one of:

  • feat: or feat(scope): new feature
  • fix: or fix(scope): bug fix
  • docs: or docs(scope): documentation changes
  • chore: or chore(scope): maintenance tasks
  • refactor: or refactor(scope): code refactoring
  • test: or test(scope): adding or updating tests

Where scope is the package name (e.g., app, desktop, opencode).

See CONTRIBUTING.md for details.

@github-actions
Copy link
Contributor

The following comment was made by an LLM, it may be inaccurate:

Based on my search, I found several PRs related to file listing functionality, but none appear to be direct duplicates of PR #8191. The most relevant related PRs are:

However, these are all in different areas (system prompts, recursion logic, pagination) and don't appear to be addressing the same "@filename" undefined parameter bug that PR #8191 fixes.

No duplicate PRs found

@neriousy neriousy changed the title Fix(app): listing files fix(app): listing files Jan 13, 2026
@github-actions
Copy link
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@neriousy neriousy changed the title fix(app): listing files fix(web): listing files Jan 13, 2026
@neriousy neriousy changed the title fix(web): listing files fix(app): listing files Jan 13, 2026
@adamdotdevin
Copy link
Contributor

Thanks again, we merged this same fix earlier this morning!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants